Skip to content

[Doc] Remove Ray Client from job diagram#38337

Merged
pcmoritz merged 1 commit intoray-project:masterfrom
architkulkarni:update-job-diagram
Aug 11, 2023
Merged

[Doc] Remove Ray Client from job diagram#38337
pcmoritz merged 1 commit intoray-project:masterfrom
architkulkarni:update-job-diagram

Conversation

@architkulkarni
Copy link
Contributor

Why are these changes needed?

Removes Ray Client from the "how to submit a job" diagram because we are de-emphasizing Ray Client in the docs.

Before
ray-job-diagram
After
Ray job diagram (1)

Related issue number

Closes #32944

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcmoritz pcmoritz merged commit 29bfa85 into ray-project:master Aug 11, 2023
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
angelinalg added a commit that referenced this pull request Sep 1, 2023
Because we removed the Ray Client option in the diagram (#38337), the text needs to be updated, too.



Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
architkulkarni pushed a commit that referenced this pull request Sep 5, 2023
Because we removed the Ray Client option in the diagram (#38337), the text needs to be updated, too.

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
…project#39217)

Because we removed the Ray Client option in the diagram (ray-project#38337), the text needs to be updated, too.

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
angelinalg added a commit to angelinalg/ray that referenced this pull request Sep 5, 2023
…project#39217)

Because we removed the Ray Client option in the diagram (ray-project#38337), the text needs to be updated, too.

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
GeneDer pushed a commit that referenced this pull request Sep 5, 2023
* [DOC] Fix example gallery sidebar scrolling (#38583)

This PR fixes some irritating side bar behavior on the example gallery docs page. Currently if your browser's viewport is too short top-to-bottom, the part of the tag filter buttons side bar that you can't see won't scroll into view until you scroll all the way through all the examples in the page. This PR makes it so that the side bar can be scrolled into view if it's too big to fit into the viewport, and as a bonus it also resolves some erratic rendering that happens when the top nav bar gets hidden from view as the user scrolls down.

Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>

* [docs] rm all banner code, closes #39114 (#39197)

Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>

* [docs] update kapa plugin, disclaimers (#39198)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>

* [Doc] [Clusters] Update text to remove references to Ray Client (#39217)

Because we removed the Ray Client option in the diagram (#38337), the text needs to be updated, too.

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>

---------

Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Co-authored-by: Peyton Murray <peynmurray@gmail.com>
Co-authored-by: Max Pumperla <max.pumperla@googlemail.com>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
…project#39217)

Because we removed the Ray Client option in the diagram (ray-project#38337), the text needs to be updated, too.

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Victor <vctr.y.m@example.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…project#39217)

Because we removed the Ray Client option in the diagram (ray-project#38337), the text needs to be updated, too.

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ray Client] Remove Ray Client in Job submission picture

3 participants