[core] Fix the GCS crash when using LD_PRELOAD and make jemalloc work with worker as well#39192
Merged
fishbone merged 9 commits intoray-project:masterfrom Sep 2, 2023
Merged
Conversation
Contributor
Author
|
|
jjyao
approved these changes
Sep 1, 2023
Contributor
jjyao
left a comment
jjyao
left a comment
There was a problem hiding this comment.
What's the version of jemalloc we will be using?
scv119
approved these changes
Sep 1, 2023
Contributor
Author
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Sep 2, 2023
… with worker as well (ray-project#39192) ## Why are these changes needed? `libjemalloc` was built into gcs and raylet in [this](ray-project#38644) PR. While it fixed the memory issues it brings some issues. It'll break the workload if the user start ray with tcmalloc. It doesn't work with core worker and for some workload, we need this. This PR make the jemalloc a shared library and if there is LD_PRELOAD, it won't load jemalloc.so automatically. ## Related issue number Closes ray-project#39135
This was referenced Sep 2, 2023
GeneDer
pushed a commit
that referenced
this pull request
Sep 3, 2023
… with worker as well (#39192) (#39235) ## Why are these changes needed? `libjemalloc` was built into gcs and raylet in [this](#38644) PR. While it fixed the memory issues it brings some issues. It'll break the workload if the user start ray with tcmalloc. It doesn't work with core worker and for some workload, we need this. This PR make the jemalloc a shared library and if there is LD_PRELOAD, it won't load jemalloc.so automatically. ## Related issue number Closes #39135
LeonLuttenberger
pushed a commit
to jaidisido/ray
that referenced
this pull request
Sep 5, 2023
… with worker as well (ray-project#39192) ## Why are these changes needed? `libjemalloc` was built into gcs and raylet in [this](ray-project#38644) PR. While it fixed the memory issues it brings some issues. It'll break the workload if the user start ray with tcmalloc. It doesn't work with core worker and for some workload, we need this. This PR make the jemalloc a shared library and if there is LD_PRELOAD, it won't load jemalloc.so automatically. ## Related issue number Closes ray-project#39135
fishbone
added a commit
that referenced
this pull request
Sep 5, 2023
## Why are these changes needed? In [PR](#39192), jemalloc is added, but it's not delivered with the wheel. This PR fixed it.
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Sep 5, 2023
## Why are these changes needed? In [PR](ray-project#39192), jemalloc is added, but it's not delivered with the wheel. This PR fixed it.
8 tasks
GeneDer
pushed a commit
that referenced
this pull request
Sep 5, 2023
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
… with worker as well (ray-project#39192) ## Why are these changes needed? `libjemalloc` was built into gcs and raylet in [this](ray-project#38644) PR. While it fixed the memory issues it brings some issues. It'll break the workload if the user start ray with tcmalloc. It doesn't work with core worker and for some workload, we need this. This PR make the jemalloc a shared library and if there is LD_PRELOAD, it won't load jemalloc.so automatically. ## Related issue number Closes ray-project#39135 Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
## Why are these changes needed? In [PR](ray-project#39192), jemalloc is added, but it's not delivered with the wheel. This PR fixed it. Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
… with worker as well (ray-project#39192) ## Why are these changes needed? `libjemalloc` was built into gcs and raylet in [this](ray-project#38644) PR. While it fixed the memory issues it brings some issues. It'll break the workload if the user start ray with tcmalloc. It doesn't work with core worker and for some workload, we need this. This PR make the jemalloc a shared library and if there is LD_PRELOAD, it won't load jemalloc.so automatically. ## Related issue number Closes ray-project#39135 Signed-off-by: Victor <vctr.y.m@example.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
## Why are these changes needed? In [PR](ray-project#39192), jemalloc is added, but it's not delivered with the wheel. This PR fixed it. Signed-off-by: Victor <vctr.y.m@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
libjemallocwas built into gcs and raylet in this PR. While it fixed the memory issues it brings some issues.It'll break the workload if the user start ray with tcmalloc.
It doesn't work with core worker and for some workload, we need this.
This PR make the jemalloc a shared library and if there is LD_PRELOAD, it won't load jemalloc.so automatically.
Related issue number
Closes #39135
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.