Skip to content

[Jobs] Move JobSupervisor and JobLogStorageClient to separate files #45116

Merged
edoakes merged 4 commits intoray-project:masterfrom
nikitavemuri:nikita/refactor_job_supervisor
May 2, 2024
Merged

[Jobs] Move JobSupervisor and JobLogStorageClient to separate files #45116
edoakes merged 4 commits intoray-project:masterfrom
nikitavemuri:nikita/refactor_job_supervisor

Conversation

@nikitavemuri
Copy link
Contributor

@nikitavemuri nikitavemuri commented May 2, 2024

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests -- no logical changes so existing unit tests are sufficient
    • Release tests
    • This PR is not tested :(

Nikita Vemuri added 3 commits May 2, 2024 12:53
refactor
fbc6ab1 
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
formatting
789193d 
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
update comment
bd977c6 
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@nikitavemuri nikitavemuri marked this pull request as ready for review May 2, 2024 20:03
@nikitavemuri nikitavemuri requested a review from edoakes May 2, 2024 20:03
@nikitavemuri nikitavemuri mentioned this pull request May 2, 2024
Merged
8 tasks
formatting
98f99c5 
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
edoakes
edoakes approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyvm

@edoakes edoakes merged commit 4ac54f1 into ray-project:master May 2, 2024
alexeykudinkin added a commit that referenced this pull request May 2, 2024
@alexeykudinkin
Revert "[Jobs] Move JobSupervisor and JobLogStorageClient to separate…
e16338c 
… files (#45116)"

This reverts commit 4ac54f1.

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@rynewang rynewang mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edoakes edoakes edoakes approved these changes

Assignees

@edoakes edoakes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikitavemuri @edoakes