Skip to content

[Serve] update serve build multi app doc#45134

Merged
edoakes merged 1 commit intoray-project:masterfrom
GeneDer:update-docs-on-serve-build-multi-app
May 3, 2024
Merged

[Serve] update serve build multi app doc#45134
edoakes merged 1 commit intoray-project:masterfrom
GeneDer:update-docs-on-serve-build-multi-app

Conversation

@GeneDer
Copy link
Member

@GeneDer GeneDer commented May 3, 2024

Why are these changes needed?

A user reported the --multi-app flag doesn't work. This option is already deprecated from the previous migration work and by default the command will generate multi-app config. This PR updated the docs on example command and the resulting config. This seems to be the only place that's still mentioning --multi-app.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer GeneDer self-assigned this May 3, 2024
@edoakes edoakes merged commit 8ed218f into ray-project:master May 3, 2024
@GeneDer GeneDer deleted the update-docs-on-serve-build-multi-app branch May 3, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants