Skip to content

[Doc] Update key-concepts.md#45245

Merged
edoakes merged 1 commit intoray-project:masterfrom
antoni-jamiolkowski:patch-1
May 10, 2024
Merged

[Doc] Update key-concepts.md#45245
edoakes merged 1 commit intoray-project:masterfrom
antoni-jamiolkowski:patch-1

Conversation

@antoni-jamiolkowski
Copy link
Contributor

Why are these changes needed?

The text in the DeploymentHandle (composing deployments) paragraph of the Ray Serve documentation is not consistent with the code snippet linked below it.

Related issue number

There isn't related issue. Should I create one?

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Antoni Jamiołkowski <50143141+antoni-jamiolkowski@users.noreply.github.com>
Copy link
Collaborator

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@edoakes edoakes merged commit 3295641 into ray-project:master May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants