[Serve] Keep object_store_memory an int#45781
Merged
shrekris-anyscale merged 4 commits intoray-project:masterfrom Jun 7, 2024
Merged
[Serve] Keep object_store_memory an int#45781shrekris-anyscale merged 4 commits intoray-project:masterfrom
object_store_memory an int#45781shrekris-anyscale merged 4 commits intoray-project:masterfrom
Conversation
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
shrekris-anyscale
changed the title
object_store_memory to be setobject_store_memory an int
GeneDer
approved these changes
Jun 6, 2024
edoakes
approved these changes
Jun 6, 2024
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Co-authored-by: Gene Der Su <gdsu@ucdavis.edu> Signed-off-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com>
richardsliu
pushed a commit
to richardsliu/ray
that referenced
this pull request
Jun 12, 2024
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> Ray Serve converts `object_store_memory` into a float, but Ray Core requires it to be an int. This change makes Serve keep it an int. **Note:** I added the unit test to `test_regression.py`, but it makes more sense to keep it in `test_api.py`. I'm going to hold off on adding it there until ray-project#45780 is resolved. If I add it to `test_api.py` now, the test passes and then hangs while cleaning up. ## Related issue number <!-- For example: "Closes ray-project#1234" --> Closes ray-project#45321 ## Checks - [X] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [X] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [X] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com> Signed-off-by: shrekris-anyscale <92341594+shrekris-anyscale@users.noreply.github.com> Co-authored-by: Gene Der Su <gdsu@ucdavis.edu> Signed-off-by: Richard Liu <ricliu@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ray Serve converts
object_store_memoryinto a float, but Ray Core requires it to be an int. This change makes Serve keep it an int.Note: I added the unit test to
test_regression.py, but it makes more sense to keep it intest_api.py. I'm going to hold off on adding it there until #45780 is resolved. If I add it totest_api.pynow, the test passes and then hangs while cleaning up.Related issue number
Closes #45321
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.