[Serve] Fix return type of _DeploymentHandleBase._get_or_create_router#46480
Merged
edoakes merged 1 commit intoray-project:masterfrom Jul 11, 2024
Merged
Conversation
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
JoshKarpel
commented
Jul 8, 2024
| ) | ||
|
|
||
| def _get_or_create_router(self) -> Union[Router, asyncio.AbstractEventLoop]: | ||
| def _get_or_create_router(self) -> Tuple[Router, asyncio.AbstractEventLoop]: |
Contributor
Author
There was a problem hiding this comment.
See below, this returns a tuple of these two types, not one-or-the-other
Collaborator
There was a problem hiding this comment.
yeah, probably just a typo :)
really wish we were actually using mypy on the serve codebase...
Contributor
Author
There was a problem hiding this comment.
I would love that!
It's definitely tricky around the actual .remote() calls and whatnot that users would see, but it would be great just for internal development.
Collaborator
There was a problem hiding this comment.
yeah most of the code tries to abstract out the ray remote calls, so it shouldn't be hard in theory
JoshKarpel
changed the title
_DeploymentHandleBase._get_or_create_router_DeploymentHandleBase._get_or_create_router
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I'm definitely not using this private method in a hack in our code, and
mypyis complaining about it.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.