[serve] add cmdline options to control which microbenchmarks to run#46798
Merged
edoakes merged 2 commits intoray-project:masterfrom Jul 29, 2024
Merged
[serve] add cmdline options to control which microbenchmarks to run#46798edoakes merged 2 commits intoray-project:masterfrom
edoakes merged 2 commits intoray-project:masterfrom
Conversation
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
edoakes
reviewed
Jul 25, 2024
Comment on lines
+289
to
+294
| @click.option("--run-all", is_flag=True) | ||
| @click.option("--run-http", is_flag=True) | ||
| @click.option("--run-grpc", is_flag=True) | ||
| @click.option("--run-handle", is_flag=True) | ||
| @click.option("--run-latency", is_flag=True) | ||
| @click.option("--run-throughput", is_flag=True) |
Contributor
Author
There was a problem hiding this comment.
defaults are all False
Collaborator
There was a problem hiding this comment.
seems confusing; would suggest default runs everything (or the most common one in isolation)
Contributor
Author
There was a problem hiding this comment.
Added logic that defaults to run everything if no other flags are set!
edoakes
approved these changes
Jul 26, 2024
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Contributor
Author
|
@edoakes tests are passing, ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add command line flags that can be used to control which microbenchmarks to run. The release test pipeline will use
--run-all, but when running the script for debugging, these flags make it a lot easier to run only the tests you want.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.