Add IsHeadNode tag to node metrics#47872
Merged
pcmoritz merged 6 commits intoray-project:masterfrom Oct 25, 2024
Merged
Conversation
vigneshka
force-pushed
the
vigneshka/head-node-tag
branch
from
a601a2e to
75ed2a1
Compare
Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
vigneshka
force-pushed
the
vigneshka/head-node-tag
branch
from
75ed2a1 to
a7bd86b
Compare
vigneshka
force-pushed
the
vigneshka/head-node-tag
branch
from
3fb29e9 to
0f9efb0
Compare
Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
vigneshka
force-pushed
the
vigneshka/head-node-tag
branch
from
08fec31 to
0dfa402
Compare
Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
vigneshka
force-pushed
the
vigneshka/head-node-tag
branch
from
37a644d to
f18b6fa
Compare
pcmoritz
approved these changes
Oct 25, 2024
Contributor
pcmoritz
left a comment
pcmoritz
left a comment
There was a problem hiding this comment.
This makes sense to me, but what I currently don't understand is why are there two head nodes with different IP addresses in the graphs?
Contributor
Author
|
@pcmoritz , I think I took the screenshot between some cluster restarts. Just ran a quick job with a 2 worker cluster, and shows 1 head as expected: |
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> Adding IsHeadNode tag to node metrics <img width="1823" alt="Screenshot 2024-10-24 at 6 36 57 PM" src="https://github.com/user-attachments/assets/855919db-b08e-4966-ae50-79c6de78bd90"> <img width="1818" alt="Screenshot 2024-10-24 at 6 36 47 PM" src="https://github.com/user-attachments/assets/cb323682-d1c5-451a-98b2-eb99aff938a1"> <img width="1818" alt="Screenshot 2024-10-24 at 6 37 28 PM" src="https://github.com/user-attachments/assets/f783cd67-e7da-4230-9f02-fa2d625a17e3"> <img width="1824" alt="Screenshot 2024-10-24 at 6 38 08 PM" src="https://github.com/user-attachments/assets/08998ab1-7702-4fb3-8dea-76e5c8ab5232"> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [x] I've included any doc changes needed for https://docs.ray.io/en/master/. - [x] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [x] Release tests - [x] This PR is not tested :( --------- Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adding IsHeadNode tag to node metrics
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.