Skip to content

[Serve] refactor add_grpc_address helper#48033

Merged
edoakes merged 3 commits intoray-project:masterfrom
GeneDer:refactor-grpc-address-helper
Oct 16, 2024
Merged

[Serve] refactor add_grpc_address helper#48033
edoakes merged 3 commits intoray-project:masterfrom
GeneDer:refactor-grpc-address-helper

Conversation

@GeneDer
Copy link
Member

@GeneDer GeneDer commented Oct 15, 2024

Why are these changes needed?

Follow up on #47720 to move the helper into default_impl.py

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Gene Su <e870252314@gmail.com>
Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer GeneDer added the go add ONLY when ready to merge, run all tests label Oct 15, 2024
Signed-off-by: Gene Su <e870252314@gmail.com>
Copy link
Collaborator

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thx

@GeneDer
Copy link
Member Author

GeneDer commented Oct 16, 2024

@edoakes this is ready for merge

@edoakes edoakes merged commit 4dfa033 into ray-project:master Oct 16, 2024
@GeneDer GeneDer deleted the refactor-grpc-address-helper branch October 16, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants