[Debugger] Clarify that only one paused task can be debugged at a time#48415
Merged
[Debugger] Clarify that only one paused task can be debugged at a time#48415
Conversation
Co-authored-by: bhuang <bhuang@anyscale.com>
angelinalg
reviewed
Oct 30, 2024
Contributor
angelinalg
left a comment
angelinalg
left a comment
There was a problem hiding this comment.
Mind making these style changes?
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
Contributor
Author
|
Updated, thanks :) |
angelinalg
approved these changes
Oct 30, 2024
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
Contributor
Is there a way to add a tooltip saying something like
Any plan for this? |
Contributor
Author
|
The tooltip would be great! @brycehuang30 feel free to do that when you have time :) The automatic disconnect most likely has lower ROI and would only be worth it if we are very sure that's what the user wants (and it is not brittle). |
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
ray-project#48415) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? I was initially confused that I couldn't join another paused task while a debugger was in "continue" mode. ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Philipp Moritz <pcmoritz@gmail.com> Co-authored-by: bhuang <bhuang@anyscale.com> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I was initially confused that I couldn't join another paused task while a debugger was in "continue" mode.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.