[data] Project Operator for select_columns#48635
Merged
richardliaw merged 1 commit intoray-project:masterfrom Nov 8, 2024
Merged
[data] Project Operator for select_columns#48635richardliaw merged 1 commit intoray-project:masterfrom
richardliaw merged 1 commit intoray-project:masterfrom
Conversation
richardliaw
requested review from
alexeykudinkin,
bveeramani,
omatthew98,
raulchen,
scottjlee,
srinathk10 and
stephanie-wang
as code owners
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
richardliaw
force-pushed
the
project-api
branch
from
53544b0 to
24617e8
Compare
bveeramani
approved these changes
Nov 7, 2024
Comment on lines
+90
to
+94
| def fn(batch: "pa.Table") -> "pa.Table": | ||
| try: | ||
| return batch.select(columns) | ||
| except Exception as e: | ||
| _handle_debugger_exception(e) |
Contributor
There was a problem hiding this comment.
This will break for Pandas, right?
We'd add support for it here (until we drop it completely as an internal block format)
Contributor
Author
There was a problem hiding this comment.
No, it won't fail. We coerce the batch format into this function to be pyarrow in above -> https://github.com/ray-project/ray/pull/48635/files#diff-7aaeab5974c738dac5f137b1ba54dbb32d9fac4cfa200fe7e429ec1294863e72R251
Contributor
Author
There was a problem hiding this comment.
what's the code sample you think that may fail?
Member
There was a problem hiding this comment.
This is a batch format, so it shouldn't matter what the internal block format is, right?
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
## Why are these changes needed? Add Project operator to select_columns. ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add Project operator to select_columns.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.