[data] Fix S3 serialization wrapper compatibility with RetryingPyFileSystem
#52568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
raulchen
approved these changes
Apr 24, 2025
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
raulchen
approved these changes
Apr 24, 2025
iamjustinhsu
pushed a commit
that referenced
this pull request
May 3, 2025
…eSystem` (#52568) Fixes the bug mentioned in #52513. The S3 filesystem serialization wrapper doesn't preserve the `retryable_erros` and `wrap_retries` properties during serialization (the `__reduce__` didn't include those properties to reconstruct it properly). This PR leaves the serialization logic to the `RetryablePyFileSystem` rather than have the buggy wrapping/unwrapping. This S3 serialization wrapper cannot be removed still because there's a [deserialization issue](apache/arrow#38375) that still exists in pyarrow<14.0.0. This workaround can be removed once the lower bound pyarrow version exceeds 14.0.0. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: jhsu <jhsu@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the bug mentioned in #52513.
The S3 filesystem serialization wrapper doesn't preserve the
retryable_errosandwrap_retriesproperties during serialization (the__reduce__didn't include those properties to reconstruct it properly). This PR leaves the serialization logic to theRetryablePyFileSystemrather than have the buggy wrapping/unwrapping.This S3 serialization wrapper cannot be removed still because there's a deserialization issue that still exists in pyarrow<14.0.0.
This workaround can be removed once the lower bound pyarrow version exceeds 14.0.0.