Skip to content

Remove serialized from_random object ids in tests#7340

Merged
edoakes merged 7 commits intoray-project:masterfrom
edoakes:remove-from-random
Feb 27, 2020
Merged

Remove serialized from_random object ids in tests#7340
edoakes merged 7 commits intoray-project:masterfrom
edoakes:remove-from-random

Conversation

@edoakes
Copy link
Collaborator

@edoakes edoakes commented Feb 27, 2020

Why are these changes needed?

ObjectID.from_random is not a supported API so we shouldn't use it in tests. This replaces it with asyncio actors for synchronization.

Checks

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@stephanie-wang stephanie-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! It'd be good to move the class into utils like Simon said, but the tests look good.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22461/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22465/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22470/
Test FAILed.

@edoakes edoakes merged commit cbf55d6 into ray-project:master Feb 27, 2020
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22508/
Test FAILed.

ffbin pushed a commit to antgroup/ant-ray that referenced this pull request Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants