Revert "Revert "Add ability to specify worker and driver ports (#7833…#8071
Revert "Revert "Add ability to specify worker and driver ports (#7833…#8071edoakes merged 28 commits intoray-project:masterfrom
Conversation
…roject#7833)" (ray-project#8069)" This reverts commit 90ef585.
|
Can one of the admins verify this patch? |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
@edoakes Should this be reverted for the next releasse? |
|
@rkooo567 no. This is a "revert revert" :) |
|
Test FAILed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test FAILed. |
|
@edoakes This could be a quiet important features for many users. Do you think there's any way we can merge this by tomorrow? |
|
Note: most of the LoC changed here are due to splitting test_basic into three tests: test_basic, test_basic_2, test_serialization |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test FAILed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
This reverts commit 90ef585.
Why are these changes needed?
Adds the ability to specify a port range for workers and drivers connecting to a cluster started via
ray start. It would be ideal to default this port range, but this has caused an endless battle with CI due to port collisions. There are users who need this, so merging without a default for now.Related issue number
Checks
scripts/format.shto lint the changes in this PR.