[build.zig] Fix Zig emscripten build#4012
Merged
raysan5 merged 3 commits intoraysan5:masterfrom May 29, 2024
dylanlangston:master
Merged
[build.zig] Fix Zig emscripten build#4012raysan5 merged 3 commits intoraysan5:masterfrom dylanlangston:master
raysan5 merged 3 commits intoraysan5:masterfrom
dylanlangston:master
Conversation
Split the code for Zig's master branch and >= 0.12.0 due to changes in ziglang/zig#19623
Accidently removed a couple lines I didn't mean to 🙈
Owner
|
@dylanlangston thanks for the review! |
dylanlangston
added a commit
to dylanlangston/dylanlangston.com
that referenced
this pull request
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #4010. In Zig's master branch the path to the emsdk headers must be a relative path, as mentioned ziglang/zig#19623. Previously, in versions >= 0.12, this path was absolute.
This fix splits the code based on the current Zig version. If the current version is greater than 0.12.0 then we use a relative path and otherwise we use an absolute path. If upgrading to Zig's master branch this is a breaking change and the path supplied for the
--sysrootmust be relative to Zig's build directory.