Added minmode support for broesel cross #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added minmode support to broesel health style while also modulising last damage dealt to make it possible to switch positions without having to use the hud editor and fixing a potential overlap issue
Collaborator
|
Since this will break the editor for rayshud, that needs to be updated before merging this in. |
Collaborator
|
Sorry for the long delay. I got around to testing this and think it will be best to have one customization option where the damage number is on the left and it works regardless of whether you use minmode or not. It's cleaner this way and will be easier to maitain in the editor. I've updated and merged the PR. Thank you very much for contributing. |
Contributor
Author
|
Okay that's cool with me, whatever you think works best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added minmode support to broesel health style while also modulizing last damage dealt to make it possible to switch positions without having to use the hud editor. this also fixes a potential overlap issue, see huddamageaccount.res for more details