Skip to content

feat: support popover props in datepicker and rangepicker #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohanchkrabrty merged 2 commits into from
Sep 29, 2025
Merged

feat: support popover props in datepicker and rangepicker #537

rohanchkrabrty merged 2 commits into from
Sep 29, 2025

Conversation

@rohanchkrabrty
Copy link
Contributor

@rohanchkrabrty rohanchkrabrty commented Sep 24, 2025 •
edited by singh-pk
Loading

Description

This PR add supports for PopoverProps in the DatePicker and RangePicker components

This is a BREAKING CHANGE. The component no longer supports side prop directly. It needs to be passed inside popoverProps

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor (no functional changes, no bug fixes just code improvements)
  • Chore (changes to the build process or auxiliary tools and libraries such as documentation generation)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, etc))
  • Test (adding missing tests or correcting existing tests)
  • Improvement (Improvements to existing code)
  • Other (please specify)

How Has This Been Tested?

Automated

@rohanchkrabrty rohanchkrabrty self-assigned this Sep 24, 2025
@vercel
Copy link

vercel bot commented Sep 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
apsara Ready Ready Preview Comment Sep 24, 2025 8:59am

@rohanchkrabrty rohanchkrabrty requested review from paanSinghCoder and rsbh and removed request for rsbh September 24, 2025 08:44
@rohanchkrabrty rohanchkrabrty merged commit c490221 into main Sep 29, 2025
4 checks passed
@rohanchkrabrty rohanchkrabrty deleted the CLD-2309 branch September 29, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paanSinghCoder paanSinghCoder paanSinghCoder approved these changes

@rsbh rsbh Awaiting requested review from rsbh

Assignees

@rohanchkrabrty rohanchkrabrty

Labels

BREAKING CHANGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohanchkrabrty @paanSinghCoder