Skip to content

Conversation

@paanSinghCoder
Copy link
Contributor

@paanSinghCoder paanSinghCoder commented Nov 24, 2025

Description

Problem statement

  1. Global setup: typography.css sets font-family: var(--rs-font-body) on the body element, so all elements inherit it by default.
  2. Many components explicitly set font-family: var(--rs-font-body), which is redundant.
  3. Some components correctly use font-family: inherit (e.g., breadcrumb dropdown trigger, text-area in places).

Recommendation

Remove local font-family: var(--rs-font-body) declarations and let components inherit from body. Only set font-family when you need a different font (e.g., --rs-font-mono for code, --rs-font-title for headlines).

Keep font-family for below:

  1. headline.module.css — kept font-family: var(--rs-font-title) (title font)
  2. code-block.module.css — kept font-family: var(--rs-font-mono) (monospace font)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor (no functional changes, no bug fixes just code improvements)
  • Chore (changes to the build process or auxiliary tools and libraries such as documentation generation)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, etc))
  • Test (adding missing tests or correcting existing tests)
  • Improvement (Improvements to existing code)
  • Other (please specify)

How Has This Been Tested?

Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (.mdx files)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
apsara Ready Ready Preview Comment Nov 24, 2025 10:11am

@paanSinghCoder paanSinghCoder merged commit 32a6aee into main Nov 26, 2025
4 checks passed
@paanSinghCoder paanSinghCoder deleted the refactor/remove-font-family branch November 26, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants