Skip to content

Fix (datatable): hide table.header for no data #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paanSinghCoder merged 3 commits into from
Dec 3, 2025
Merged

Fix (datatable): hide table.header for no data #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7418bd
fix (datatable): hide header if data is not present
paanSinghCoder Nov 27, 2025
a7d3690
fix: remove bottom hr when empty state is visible
paanSinghCoder Nov 27, 2025
a729274
chore: add empty space
paanSinghCoder Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 102 additions & 0 deletions apps/www/src/app/examples/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
AvatarGroup,
Button,
Callout,
DataTable,
DatePicker,
Dialog,
DropdownMenu,
Expand Down Expand Up @@ -1957,6 +1958,107 @@ const Page = () => {
</Flex>
</Flex>

<Text
size='large'
weight='medium'
style={{ marginTop: '32px', marginBottom: '16px' }}
>
DataTable Examples
</Text>

<Flex direction='column' gap={6}>
<Flex direction='column' gap={3}>
<DataTable
data={[
{
id: '1',
name: 'John Doe',
email: 'john@example.com',
role: 'Admin'
},
{
id: '2',
name: 'Jane Smith',
email: 'jane@example.com',
role: 'User'
},
{
id: '3',
name: 'Bob Johnson',
email: 'bob@example.com',
role: 'User'
}
]}
columns={[
{
accessorKey: 'name',
header: 'Name',
enableColumnFilter: true
},
{
accessorKey: 'email',
header: 'Email',
enableColumnFilter: true
},
{
accessorKey: 'role',
header: 'Role',
enableColumnFilter: true
}
]}
mode='client'
defaultSort={{ name: 'name', order: 'asc' }}
>
<DataTable.Toolbar />
<DataTable.Content
emptyState={
<EmptyState
icon={<FilterIcon />}
heading='No users found'
subHeading="We couldn't find any matches for that keyword or filter. Try alternative terms or check for typos."
/>
}
/>
</DataTable>
</Flex>

<Flex direction='column' gap={3}>
<DataTable
data={[]}
columns={[
{
accessorKey: 'name',
header: 'Name',
enableColumnFilter: true
},
{
accessorKey: 'email',
header: 'Email',
enableColumnFilter: true
},
{
accessorKey: 'role',
header: 'Role',
enableColumnFilter: true
}
]}
mode='client'
defaultSort={{ name: 'name', order: 'asc' }}
>
<DataTable.Toolbar />
<DataTable.Content
emptyState={
<EmptyState
icon={<FilterIcon />}
heading='No users found'
subHeading="We couldn't find any matches for that keyword or filter. Try alternative terms or check for typos."
/>
}
/>
</DataTable>
</Flex>
</Flex>

<Flex justify='center' style={{ marginTop: 40 }}>
<Button type='submit'>Submit button</Button>
</Flex>
Expand Down
13 changes: 10 additions & 3 deletions packages/raystack/components/data-table/components/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,12 +218,16 @@ export function Content({

const visibleColumnsLength = table.getVisibleLeafColumns().length;

const hasData = rows?.length > 0 || isLoading;

return (
<div className={classNames.root}>
<Table className={classNames.table}>
<Headers headerGroups={headerGroups} className={classNames.header} />
{hasData && (
<Headers headerGroups={headerGroups} className={classNames.header} />
)}
<Table.Body className={classNames.body}>
{rows?.length || isLoading ? (
{hasData ? (
<>
<Rows
rows={rows}
Expand All @@ -242,7 +246,10 @@ export function Content({
</>
) : (
<Table.Row>
<Table.Cell colSpan={visibleColumnsLength}>
<Table.Cell
colSpan={visibleColumnsLength}
className={styles.emptyStateCell}
>
{emptyState || <DefaultEmptyComponent />}
</Table.Cell>
</Table.Row>
Expand Down
4 changes: 4 additions & 0 deletions packages/raystack/components/data-table/data-table.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,7 @@
.cell {
background: inherit;
}

.emptyStateCell {
border-bottom: none;
}