Skip to content

Conversation

@paanSinghCoder
Copy link
Contributor

@paanSinghCoder paanSinghCoder commented Dec 2, 2025

Description

Add navbar component

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor (no functional changes, no bug fixes just code improvements)
  • Chore (changes to the build process or auxiliary tools and libraries such as documentation generation)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, etc))
  • Test (adding missing tests or correcting existing tests)
  • Improvement (Improvements to existing code)
  • Other (please specify)

How Has This Been Tested?

manual and unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (.mdx files)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Screenshots (if appropriate):

[Add screenshots here]

Related Issues

[Link any related issues here using #issue-number]

@vercel
Copy link

vercel bot commented Dec 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
apsara Ready Ready Preview Comment Dec 8, 2025 10:28am

@paanSinghCoder paanSinghCoder changed the title Feat/navbar feat: add navbar component Dec 3, 2025
Copy link
Contributor

@rohanchkrabrty rohanchkrabrty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel it's better to keep the following structure

<Navbar>
  <Navbar.Section/>
  <Navbar.Section/>
</Navbar>

The navbar can have multiple sections too and not limited by start,end nomenclature

@paanSinghCoder
Copy link
Contributor Author

@rohanchkrabrty I think start/end makes better sense here:

  1. start/end indicates the purpose and clarity. Section is way too generic and doesn't indicate the position.
  2. There is one more possible position that can be added is center. We can have Navbar.Center later if design requires it.
  3. In the Sidebar component as well we have very specific names - Header, main and footer.
  4. start/end helps with RTL support (if we add it in future).

cc: @rsbh

@paanSinghCoder paanSinghCoder merged commit 07e654a into main Dec 9, 2025
4 checks passed
@paanSinghCoder paanSinghCoder deleted the feat/navbar branch December 9, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants