Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

Add tags_JSON to BackendEntityView and SpanEventView#125

Open
suddendust wants to merge 3 commits intorzp_mainfrom
tags_json
Open

Add tags_JSON to BackendEntityView and SpanEventView#125
suddendust wants to merge 3 commits intorzp_mainfrom
tags_json

Conversation

@suddendust
Copy link
Copy Markdown

@suddendust suddendust commented Jan 16, 2023

  • Leaves tags as is because tags__KEYS and tags__VALUES are derived from this column.
  • Both of these columns are still needed for running LIKE and IN queries on Explorer.
  • tags_json is a string serialised as a JSON string. The corresponding datatype in Pinot is JSON.
  • We'll run only CONTAINS_KEY and EQUALS queries on this column, as there's no way to run these queries using the json index natively.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 16, 2023

Codecov Report

Merging #125 (95a5c32) into rzp_main (fbbd57d) will decrease coverage by 0.02%.
The diff coverage is 93.05%.

@@              Coverage Diff               @@
##             rzp_main     #125      +/-   ##
==============================================
- Coverage       80.69%   80.66%   -0.03%     
  Complexity       1359     1359              
==============================================
  Files             120      120              
  Lines            5345     5353       +8     
  Branches          495      495              
==============================================
+ Hits             4313     4318       +5     
- Misses            808      811       +3     
  Partials          224      224              
Flag Coverage Δ
unit 80.66% <93.05%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ewgenerator/generators/SpanEventViewGenerator.java 90.71% <92.85%> (-1.83%) ⬇️
...nerator/generators/BackendEntityViewGenerator.java 89.85% <100.00%> (+0.14%) ⬆️
...ce/viewgenerator/generators/BaseViewGenerator.java 81.81% <100.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Copy Markdown

Unit Test Results

  78 files  ±0    78 suites  ±0   59s ⏱️ -1s
405 tests +1  405 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 95a5c32. ± Comparison against base commit fbbd57d.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant