This repository was archived by the owner on Nov 14, 2023. It is now read-only.
Add tags_JSON to BackendEntityView and SpanEventView#125
Open
suddendust wants to merge 3 commits intorzp_mainfrom
Open
Add tags_JSON to BackendEntityView and SpanEventView#125suddendust wants to merge 3 commits intorzp_mainfrom
suddendust wants to merge 3 commits intorzp_mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## rzp_main #125 +/- ##
==============================================
- Coverage 80.69% 80.66% -0.03%
Complexity 1359 1359
==============================================
Files 120 120
Lines 5345 5353 +8
Branches 495 495
==============================================
+ Hits 4313 4318 +5
- Misses 808 811 +3
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tagsas is becausetags__KEYSandtags__VALUESare derived from this column.LIKEandINqueries on Explorer.tags_jsonis a string serialised as a JSON string. The corresponding datatype in Pinot isJSON.CONTAINS_KEYandEQUALSqueries on this column, as there's no way to run these queries using the json index natively.