Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

changes for codecov#42

Merged
TriptiTripathi1234 merged 8 commits intorzp_mainfrom
adding_codecov
Aug 25, 2022
Merged

changes for codecov#42
TriptiTripathi1234 merged 8 commits intorzp_mainfrom
adding_codecov

Conversation

@TriptiTripathi1234
Copy link
Copy Markdown

No description provided.

@TriptiTripathi1234 TriptiTripathi1234 force-pushed the adding_codecov branch 2 times, most recently from e768def to d5cfec7 Compare August 25, 2022 10:45
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (rzp_main@158eb5a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 28e2708 differs from pull request most recent head d929069. Consider uploading reports for the commit d929069 to get more accurate results

@@             Coverage Diff             @@
##             rzp_main      #42   +/-   ##
===========================================
  Coverage            ?   79.60%           
  Complexity          ?     1306           
===========================================
  Files               ?      117           
  Lines               ?     5223           
  Branches            ?      474           
===========================================
  Hits                ?     4158           
  Misses              ?      853           
  Partials            ?      212           
Flag Coverage Δ
unit 79.60% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown

@jaywalker21 jaywalker21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TriptiTripathi1234
Can you change branch name in pr-test.yml and pr-build.yml to rzp_main?

Comment thread .github/workflows/pr-test.yml Outdated
Comment thread .github/codecov.yml Outdated
@@ -0,0 +1,2 @@
codecov:
branch: rzp_main # Default branch No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not required, if using codecov/codecov-action@v2 in pr-test.yml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, codecov was taking default branch as main for some reason, even though we had rzp_main.
Had to put this to have it in sync.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before this change, it was failing and report was not added in PR comment. Check out here

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think pr-test was running on main branch, did you try rzp_main in pr-test.yml?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes still same issue

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after merge, the code will be present in rzp_main, then i think it will work as expected

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@TriptiTripathi1234 TriptiTripathi1234 merged commit 1e6a206 into rzp_main Aug 25, 2022
@github-actions
Copy link
Copy Markdown

Unit Test Results

  75 files    75 suites   1m 2s ⏱️
396 tests 396 ✔️ 0 💤 0 ❌

Results for commit 1e6a206.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants