Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

fix: failing tests in operation-utilities#114

Merged
cseas merged 1 commit intorzp_mainfrom
fix-operation-tests
Dec 19, 2022
Merged

fix: failing tests in operation-utilities#114
cseas merged 1 commit intorzp_mainfrom
fix-operation-tests

Conversation

@cseas
Copy link
Copy Markdown

@cseas cseas commented Dec 19, 2022

Description

These tests were passing on Friday but are now failing checks in every PR.
Need to set jest's system time to that date.

Package downgrade is required because jest-* libraries need to be on the same version for modern fake timers to work.
We can either upgrade jest to v27 or downgrade jest-config to v26. Downgrading is quicker since we're low on bandwidth.

Testing

All tests passing now.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@github-actions

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2022

Codecov Report

Merging #114 (6e157dc) into rzp_main (34afe6b) will increase coverage by 5.37%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           rzp_main     #114      +/-   ##
============================================
+ Coverage     76.32%   81.70%   +5.37%     
============================================
  Files           933      933              
  Lines         20133    20133              
  Branches       2740     2740              
============================================
+ Hits          15366    16449    +1083     
+ Misses         4561     3530    -1031     
+ Partials        206      154      -52     
Impacted Files Coverage Δ
...components/src/table/data/table-cdk-data-source.ts 82.83% <0.00%> (+0.74%) ⬆️
...ggle-button-group/toggle-button-group.component.ts 94.11% <0.00%> (+1.96%) ⬆️
...onents/stepper/contents/step-contents.component.ts 100.00% <0.00%> (+2.12%) ⬆️
...ojects/common/src/utilities/math/math-utilities.ts 76.74% <0.00%> (+2.32%) ⬆️
...nents/src/filtering/filter/parser/parsed-filter.ts 88.88% <0.00%> (+2.77%) ⬆️
...omponents/src/header/page/page-header.component.ts 78.78% <0.00%> (+3.03%) ⬆️
...ects/common/src/telemetry/track/track.directive.ts 100.00% <0.00%> (+3.22%) ⬆️
...mponents/src/feature-check/if-feature.directive.ts 100.00% <0.00%> (+4.34%) ⬆️
...y-error-percentage-timeseries-data-source.model.ts 31.70% <0.00%> (+4.87%) ⬆️
...shboard/widgets/table/table-widget-column.model.ts 100.00% <0.00%> (+6.45%) ⬆️
... and 150 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cseas cseas merged commit dbc9a19 into rzp_main Dec 19, 2022
@cseas cseas deleted the fix-operation-tests branch December 19, 2022 08:31
@github-actions
Copy link
Copy Markdown

Unit Test Results

       4 files  ±0     303 suites  ±0   22m 36s ⏱️ - 2m 16s
1 087 tests ±0  1 087 ✔️ +2  0 💤 ±0  0 ❌  - 2 
1 095 runs  ±0  1 095 ✔️ +2  0 💤 ±0  0 ❌  - 2 

Results for commit dbc9a19. ± Comparison against base commit 34afe6b.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants