RudderStack Analytics Integration with HyperTrace by jaywalker21 · Pull Request #27 · razorpay/hypertrace-ui

jaywalker21 · 2022-04-05T15:41:11Z

This PR introduces a mechanism to manage secrets for HT UI.
It also adds support for RudderStack Analytics in the application.

)

) * feat: add additional specification array to entity spec * refactor: fixing test * refactor: fix test * refactor: fix test * refactor: fix test * refactor: fix test again

Co-authored-by: Patricio Albizu <patricioalbizu@Patricios-MacBook-Pro.local>

…#1254) * refactor: breadcrumb to support additional specifications * refactor: fixing lint * refactor: fix test * refactor: addressing review comments * refactor: fixing test * refactor: fixing lint * refactor: addressing review comments * refactor: fixing test * refactor: update breadcrumb and fix tests

…#1259)

)

* feat: Adding properties to Title Content * feat: Fixing comments * feat: fixing comments Co-authored-by: Patricio Albizu <patricioalbizu@Patricios-MacBook-Pro.local>

…ce#1264) * fix: common project should not depend on components project

Snyk has created this PR to upgrade graphql from 15.6.1 to 15.7.0. See this package in npm: https://www.npmjs.com/package/graphql See this project in Snyk: https://app.snyk.io/org/surajpuvvada/project/553e7174-0e22-4c7f-aa2c-12ae5f5768b5?utm_source=github&utm_medium=referral&page=upgrade-pr

…hypertrace#1267)

* feat: use local storage to persist table columns * fix: typo * style: lint * style: prettier

…e#1269)

* feat: util methods to manipulate graphqlTimeRange

…ace#1274)

Snyk has created this PR to upgrade graphql from 15.7.0 to 15.7.2. See this package in npm: https://www.npmjs.com/package/graphql See this project in Snyk: https://app.snyk.io/org/saxenakshitiz/project/f89d1009-f321-4082-a83b-34ae0ca070eb?utm_source=github&utm_medium=referral&page=upgrade-pr

* fix: new style for title in titled content

…ce#1289)

…1292)

…ntegration

Sunn-y-Arora · 2022-04-06T05:37:08Z

@@ -0,0 +1,3 @@
+touch secrets.js
+echo "window.RUDDERSTACK_HT_WRITE_KEY = \"$RUDDERSTACK_HT_WRITE_KEY\";" > secrets.js


1 case, secret not found what will happen then.
eg -> in perf/devstack we wont be adding this rigth, so u want to add dummy values in secret or handle it in code
(best would be to add dummy, so code remains same)

We need a way to first check if analytics(rudderstack) is enabled and then execute this. Else, for those who don't want this, it might end up failing.

Will add the feature flag kinda stuff so it can be dynamically enabled and disabled.

Added feature flag for analytics

cseas

LGTM. Left minor suggestions.

github-actions · 2022-04-06T09:18:59Z

Unit Test Results

      4 files ±0   289 suites ±0 20m 32s ⏱️ - 3m 54s
1 040 tests ±0 1 040 ✔️ ±0 0 💤 ±0 0 ❌ ±0
1 048 runs ±0 1 048 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 6f64b89. ± Comparison against base commit 7c4c1cd.

jake-bassett and others added 30 commits November 9, 2021 15:54

feat: hide header divider line when in detail list mode (hypertrace#1246

bba10d4

)

feat: add additional specification array to entity spec (hypertrace#1247

586da92

) * feat: add additional specification array to entity spec * refactor: fixing test * refactor: fix test * refactor: fix test * refactor: fix test * refactor: fix test again

fix: make explorer content scrollable (hypertrace#1248)

0d793a2

feat: import filter url service (hypertrace#1251)

0eff64f

Co-authored-by: Patricio Albizu <patricioalbizu@Patricios-MacBook-Pro.local>

fix: make divider 1px high (hypertrace#1253)

a9293f3

feat: persist explorer state in url (hypertrace#1257)

e9cdabe

chore:(deps): bump core-js from 3.19.0 to 3.19.1 (hypertrace#1261)

756d8f4

chore:(deps-dev): bump @commitlint/config-conventional (hypertrace#1260)

2f4c2b3

chore:(deps): bump mixpanel-browser from 2.41.0 to 2.42.0 (hypertrace…

6bc351d

…#1259)

chore:(deps): bump @apollo/client from 3.4.16 to 3.4.17 (hypertrace#1263

5ee7d10

)

feat: Adding properties to Title Content (hypertrace#1235)

7013af5

* feat: Adding properties to Title Content * feat: Fixing comments * feat: fixing comments Co-authored-by: Patricio Albizu <patricioalbizu@Patricios-MacBook-Pro.local>

fix: common project should not depend on components project (hypertra…

3cc0402

…ce#1264) * fix: common project should not depend on components project

feat: adding loading config functionality to table view toggle widget (…

21247f9

…hypertrace#1267)

Table use local storage for columns (hypertrace#1265)

6803f3b

* feat: use local storage to persist table columns * fix: typo * style: lint * style: prettier

fix: avoid dupe columns, clear group name from url on none (hypertrac…

612c72a

…e#1269)

feat: util methods to manipulate graphqlTimeRange (hypertrace#1271)

e14d879

* feat: util methods to manipulate graphqlTimeRange

chore:(deps-dev): bump husky from 7.0.1 to 7.0.4 (hypertrace#1276)

011cda2

chore:(deps-dev): bump @commitlint/cli from 13.1.0 to 15.0.0 (hypertr…

b9eefdb

…ace#1274)

chore:(deps-dev): bump ts-node from 10.2.1 to 10.4.0 (hypertrace#1277)

0236f33

fix: new style for title in titled content (hypertrace#1283)

965c0c2

* fix: new style for title in titled content

fix: emit correct shape for single select change (hypertrace#1284)

f042275

feat: change default visualization for spans to count (hypertrace#1272)

70f6e9a

feat: add styling to table filters with applied values (hypertrace#1285)

b35921e

fix: support for custom row size for table (hypertrace#1286)

11f2a78

chore:(deps-dev): bump @types/node from 16.7.10 to 16.11.10 (hypertra…

dd933a7

…ce#1289)

chore:(deps-dev): bump jest-config from 27.3.1 to 27.4.0 (hypertrace#…

7870e97

…1292)

chore:(deps): bump @apollo/client from 3.4.17 to 3.5.5 (hypertrace#1291)

aa91526

jaywalker21 added 7 commits April 5, 2022 17:23

Merge branch 'feature/telemetry-rudderstack' into feature/analytics-i…

d60b83d

…ntegration

chore: add identify step in user telemetry orchestration service

e4ad06c

feat: add rudderstack provider import in root module

691fa7b

fix: gracefully handle load failure in rudderstack provider

f208a7f

fix: remove usertelemetry module import from config module

5bac8ab

feat: support to inject values from secrets.js file to window

1c614cc

feat: copy secrets script and dockerfile entrypoint added

a53a03e

jaywalker21 self-assigned this Apr 5, 2022

jaywalker21 requested review from Sunn-y-Arora and suddendust April 5, 2022 15:41

This comment has been minimized.

Sign in to view

akashmane1598 reviewed Apr 6, 2022

View reviewed changes

Comment thread projects/common/src/telemetry/providers/rudderstack/rudderstack-provider.ts

Sunn-y-Arora reviewed Apr 6, 2022

View reviewed changes

cseas approved these changes Apr 6, 2022

View reviewed changes

Comment thread src/app/root.module.ts

Comment thread src/secrets.js

jaywalker21 added 7 commits April 6, 2022 12:49

chore: add warning message for secrets file

f99aa0d

feat: conditionally enable analytics

c67c301

chore: add exec permission for shell script

0eb6ed7

chore: add default value for analytics flag to secret file

720d43f

chore: add ENABLE_ANALYTICS field to window interface

f01db57

feat: conditionally initialise user telemetry service

535e763

fix: handle string matching for analytics flag

fbb21aa

This comment has been minimized.

Sign in to view

jaywalker21 requested review from Sunn-y-Arora, akashmane1598, cseas and venkatvghub April 6, 2022 08:13

cseas approved these changes Apr 6, 2022

View reviewed changes

jaywalker21 merged commit 6f64b89 into rzp_main Apr 6, 2022

jaywalker21 deleted the feature/analytics-integration branch April 6, 2022 09:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RudderStack Analytics Integration with HyperTrace#27

RudderStack Analytics Integration with HyperTrace#27
jaywalker21 merged 274 commits intorzp_mainfrom
feature/analytics-integration

jaywalker21 commented Apr 5, 2022

Uh oh!

This comment has been minimized.

Uh oh!

Sunn-y-Arora Apr 6, 2022

Uh oh!

venkatvghub Apr 6, 2022

Uh oh!

jaywalker21 Apr 6, 2022

Uh oh!

jaywalker21 Apr 6, 2022

Uh oh!

cseas left a comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot commented Apr 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

		@@ -0,0 +1,3 @@
		touch secrets.js
		echo "window.RUDDERSTACK_HT_WRITE_KEY = \"$RUDDERSTACK_HT_WRITE_KEY\";" > secrets.js

Conversation

jaywalker21 commented Apr 5, 2022

Uh oh!

This comment has been minimized.

Uh oh!

Sunn-y-Arora Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

venkatvghub Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

jaywalker21 Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

jaywalker21 Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

cseas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot commented Apr 6, 2022

Unit Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants