Add findPage helper to JooqBaseEntityRepository#238
Merged
Conversation
vooft
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JooqBaseEntityRepository(the base forCreatableEntityrepos) didn't expose a paging helper, so consumers had to reach for rawqueryExecutor.executeSelectand reimplement the seek/paging plumbing locally. This addsfindPagemirroring the one onJooqBaseModelRepository, reusing the samePagingStrategycontract andBasicPagedListwiring — and extracts the shared body so the two repositories don't carry mirrored code.Scope
PagingExecution.ktwith internalexecuteFindPage(...)carrying the seek/select/map body shared by both repositories.findPagemethod onJooqBaseEntityRepositorydelegating toexecuteFindPage, with the same generics and contract as the model-repository version.JooqBaseModelRepository.findPagerefactored to delegate toexecuteFindPage(wasallRecords(... .page(...))plus a privateSelectConditionStep<R>.pageextension — both gone).JooqBaseModelRepository'squeryExecutorconstructor parameter is now stored as a private field so it can be passed to the shared helper. Constructor signature unchanged.