RFC: Additional SSL error reporting in verbose mode.#179
Merged
rbsec merged 4 commits intorbsec:masterfrom Jun 16, 2019
Merged
Conversation
Fix use after free of ssl object. (rbsec#178)
Add a function to convert SSL error codes to a string. In addition, get the underlying error from OpenSSL and display it. Before: [...] Accepted TLSv1.0 128 bits AES128-SHA SSL_get_error(ssl, cipherStatus) said: 1 After: [...] Accepted TLSv1.0 128 bits AES128-SHA SSL_get_error(ssl, cipherStatus) returned: 1 (SSL_ERROR_SSL) [sslscan.c:testCipher@1584]:error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number
RFC: Additional SSL error reporting in verbose mode.
Owner
|
@MarcT512 thanks for this - it's certainly more useful to have the readable error codes for debugging (even if some of them aren't actually that useful). Bit awkward having the lookup table (there might be an OpenSSL header that we could include that has it?), but then some many things are awkward in OpenSSL.... ~rbsec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a function to convert SSL error codes to a string.
In addition, get the underlying error from OpenSSL and display it (when in verbose mode).
Before:
[...]
Accepted TLSv1.0 128 bits AES128-SHA
SSL_get_error(ssl, cipherStatus) said: 1
After:
[...]
Accepted TLSv1.0 128 bits AES128-SHA
SSL_get_error(ssl, cipherStatus) returned: 1 (SSL_ERROR_SSL)
[sslscan.c:testCipher@1584]:error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number