Converted "return" to "raise" for invalid values in cdc.py & uk_who.py#52
Open
rscottweekly wants to merge 1 commit intorcpch:livefrom
Open
Converted "return" to "raise" for invalid values in cdc.py & uk_who.py#52rscottweekly wants to merge 1 commit intorcpch:livefrom
rscottweekly wants to merge 1 commit intorcpch:livefrom
Conversation
Member
|
So sorry to be slow to reply. Thank you @rscottweekly for this. Yes please - would you be happy to update this PR with some tests for this? |
Author
|
Yep - happy to do so though will be a little bit due to the holiday period.
… On 28 Dec 2024, at 6:12 AM, Simon Chapman ***@***.***> wrote:
So sorry to be slow to reply. Thank you @rscottweekly <https://github.com/rscottweekly> for this. Yes please - would you be happy to update this PR with some tests for this?
—
Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE2ZWF4VO6OXRCFZGXTBS5L2HWC6PAVCNFSM6AAAAABT3HVWM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRTHA4DGMJWGY>.
You are receiving this because you were mentioned.
|
Member
|
@rscottweekly very grateful for this - let me know if you need any support. There is no time pressure here, only reaching out in case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Changing the return Error to Raise Error as discussed in #51
Code changes
As above
Related Issues
Tests have all passed
There's no testing of error pathways - not sure if you'd like me to look into this as well?
Mentions
@eatyourpeas