Skip to content

datasets.py -> olshausen.py + refactor#33

Merged
alvinzz merged 14 commits intomainfrom
alvin/olshausen_dataset
Jun 1, 2022
Merged

datasets.py -> olshausen.py + refactor#33
alvinzz merged 14 commits intomainfrom
alvin/olshausen_dataset

Conversation

@alvinzz
Copy link
Collaborator

@alvinzz alvinzz commented May 25, 2022

No description provided.

@alvinzz alvinzz requested review from belsten and cshewmake2 May 25, 2022 16:09
@alvinzz alvinzz force-pushed the alvin/olshausen_dataset branch from fa88137 to 71d609d Compare May 25, 2022 16:14
@cshewmake2
Copy link
Contributor

Not sure if this is the right place either. For users who install the repo via pip, the data will be tucked away into the directory where pip installs the package: <virtualenv_name>/lib/<python_ver>/site-packages (link)

This means that the library itself will inflate by 20MB (the new file size) on their system. Also, it may be hard for people to inspect the data themselves.

Anyway, I'm happy to go ahead and include this to start until we figure out a better way.

Base automatically changed from alvin/patchify to main June 1, 2022 21:50
@alvinzz alvinzz merged commit c79efd9 into main Jun 1, 2022
from torch.utils.data import Dataset

from sparsecoding.data.datasets.common import RAW_DATA_DIR
from sparsecoding.data.transform.patch import patchify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throws an error because the module is sparsecoding.data.transforms.patch. This one's missing an s. Perhaps the naming convention changed between this branch and your others? Works fine with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants