Open
Conversation
Removed default display pins on line 48 (different between esp32 and esp8266), set default columns to 8 in line 49, and fixed a typo (changed lines to rows) on line 60.
Owner
|
Thank you for your pull request. I see you've adjusted some of the default constructor parameters, likely to better suit your use case. However, because these parameters are only defaults, they’re designed to work for a broad range of users and can be easily overridden when initializing the library. Changing them in the core code could impact other users without adding significant benefit. The typo in the comments regarding lines is a good catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed default display pins on line 48 (different between esp32 and esp8266), set default columns to 8 in line 49, and fixed a typo (changed lines to rows) on line 60.