Master #1
Merged
Master #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See my discussion with Will in the PR.
More clear.
Addresses Will's comments.
Next commit will address Will's comments about the typings being weird.
Makes typing much easier. Addresse's Will's last comment.
Unfortunately we can't use node-mocks-http to test a express.Router that has async routes. See eugef/node-mocks-http#225 router will just return undefined if the executing handler is async and so the test will have no way to wait for it to complete. Thus, we have to use supertest which starts an actual HTTP server in the background and uses a HTTP client to send requests.
Plugin API to add more applications to code-server
That's the default so it's extra visual noise.
refactor (vscode): migrate from submodule to subtree
Now we support pretty much every variable under the sun along with $NO_PROXY all correctly and with minimal code on our end.
We don't have an agent for FreeBSD right now.
Now that we've moved to the submodule, there is no need to reset changes in there :) cc @jsjoeio
Electron doesn't support FreeBSD.
Co-authored-by: Anmol Sethi <hi@nhooyr.io>
Capital letters in the CLI are evil. cc @code-asher
Cases in URLs like ?&a=b or ?a=b& appear to be handled just fine.
ci: Add support for FreeBSD to the build process
proxy-agent: Use proxy-from-env and add docs
Update ipad.md
Symlink node_modules.asar to node_modules in lib/vscode
Fix GitHub auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.