RDKEMW-16534: Set memory+swap to be unlimited if swap limit is not set#440
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Changes Dobby's default swap behavior so that when swapLimit is not set in a Dobby spec, memory.memsw.limit_in_bytes is left unlimited (-1) instead of being capped at memLimit. Tests and documentation are updated accordingly.
Changes:
- In
DobbySpecConfig, setMEM_SWAPto-1whenswapLimitis omitted instead of mirroringmemLimit. - Update L1 unit test to expect
SWAP=-1and rename it to reflect the new default. - Update L2 swap-limit test to validate "unlimited" semantics (with a sentinel and >1 TiB threshold), and update README accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bundle/lib/source/DobbySpecConfig.cpp | Defaults MEM_SWAP template value to -1 (unlimited) when swapLimit absent. |
| tests/L1_testing/tests/DobbySpecConfigTest/DobbySpecConfigTest.cpp | Updates the L1 test to assert the new -1 default. |
| tests/L2_testing/test_runner/swap_limit_tests.py | Adds an UNLIMITED sentinel and threshold check; switches the test container_id to ram (which reads the wrong cgroup file). |
| README.md | Documents the new unlimited default for swapLimit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
goruklu
previously approved these changes
May 14, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
rajil-jackson
approved these changes
May 15, 2026
madanagopalt
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If swap limit is not set explicitly, set memory+swap to be unlimited by default
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updatingSRC_REV)