Skip to content

RDKEMW-16534: Set memory+swap to be unlimited if swap limit is not set#440

Merged
ks734 merged 3 commits into
developfrom
topic/RDKEMW-16534_1
May 15, 2026
Merged

RDKEMW-16534: Set memory+swap to be unlimited if swap limit is not set#440
ks734 merged 3 commits into
developfrom
topic/RDKEMW-16534_1

Conversation

@ks734
Copy link
Copy Markdown
Contributor

@ks734 ks734 commented May 14, 2026

Description

If swap limit is not set explicitly, set memory+swap to be unlimited by default

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (doesn't fit into the above categories - e.g. documentation updates)

Requires Bitbake Recipe changes?

  • The base Bitbake recipe (meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updating SRC_REV)

Copilot AI review requested due to automatic review settings May 14, 2026 10:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Changes Dobby's default swap behavior so that when swapLimit is not set in a Dobby spec, memory.memsw.limit_in_bytes is left unlimited (-1) instead of being capped at memLimit. Tests and documentation are updated accordingly.

Changes:

  • In DobbySpecConfig, set MEM_SWAP to -1 when swapLimit is omitted instead of mirroring memLimit.
  • Update L1 unit test to expect SWAP=-1 and rename it to reflect the new default.
  • Update L2 swap-limit test to validate "unlimited" semantics (with a sentinel and >1 TiB threshold), and update README accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
bundle/lib/source/DobbySpecConfig.cpp Defaults MEM_SWAP template value to -1 (unlimited) when swapLimit absent.
tests/L1_testing/tests/DobbySpecConfigTest/DobbySpecConfigTest.cpp Updates the L1 test to assert the new -1 default.
tests/L2_testing/test_runner/swap_limit_tests.py Adds an UNLIMITED sentinel and threshold check; switches the test container_id to ram (which reads the wrong cgroup file).
README.md Documents the new unlimited default for swapLimit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/L2_testing/test_runner/swap_limit_tests.py Outdated
goruklu
goruklu previously approved these changes May 14, 2026
ks734 and others added 2 commits May 15, 2026 08:49
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 15, 2026 05:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@ks734 ks734 merged commit ace600c into develop May 15, 2026
42 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants