Merged
Conversation
zghp
added this to the
python_raft 1.6.0: Create Audio Amplifier Controller module milestone
TB-1993
requested changes
Jun 25, 2025
| await self.receiver.async_power_off() | ||
|
|
||
| async def set_volume(self, volume: float): | ||
| await self.receiver.async_set_volume(volume) |
Contributor
There was a problem hiding this comment.
If we decide volume is better as an Int (0 - 100), we can convert it to a float here if required (especially if the denon set_volume method expects a range from 0 - 1)
Contributor
|
Still missing the core/ audioamplifier class to read the config and differentiate itself into one of the supported controllers. |
TB-1993
requested changes
Jul 14, 2025
TB-1993
requested changes
Jul 14, 2025
TB-1993
requested changes
Jul 15, 2025
TB-1993
approved these changes
Jul 15, 2025
Contributor
TB-1993
left a comment
TB-1993
left a comment
There was a problem hiding this comment.
Looks good to me, ship it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.