Skip to content

GH173 - Missing result validation before JSON parsing in getPowerLevel #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zghp merged 1 commit into from
Jul 24, 2025
Merged

GH173 - Missing result validation before JSON parsing in getPowerLevel #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions framework/core/powerModules/tapoControl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,9 +257,20 @@ def getPowerLevel(self):
raise RuntimeError("Power monitoring is not yet supported for Tapo strips")
else:
result = self._performCommand("emeter", json=True)
result = json.loads(result)

if not result:
raise ValueError("Received empty response from Tapo device for power monitoring")

try:
result = json.loads(result)
except json.JSONDecodeError as e:
raise ValueError(f"Failed to parse JSON from Tapo device response: {e}")

millewatt = result.get('power_mw')
if millewatt:
power = int(millewatt) / 1000
return power
raise KeyError("The dictionary return for the Tapo device did is not formed as expected.")
try:
power = int(millewatt) / 1000
return power
except:
raise ValueError(f"Invalid value for power_mw: {millewatt}")
raise KeyError("The dictionary returned by the Tapo device does not contain a valid 'power_mw' value.")