Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates core communications modules to better handle password-less SSH usage and modernize serial input flushing.
Changes:
- Update
sshConsole.open()connection logic to branch between key-based auth and password-only auth. - Replace deprecated PySerial
flushInput()withreset_input_buffer()in the serial console flush routine.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
framework/core/commandModules/sshConsole.py |
Adjusts Paramiko connection parameters depending on whether a key file is provided. |
framework/core/commandModules/serialClass.py |
Updates serial buffer flush to use the modern PySerial API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TB-1993
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to allow use of SSH with no password. Default LAN ssh scenario.