Skip to content

Remove unwanted spaces in view tag templates (#556)#1508

Merged
jochenklar merged 2 commits into2.5.0/releasefrom
2.5.0/fix/view-tags
Jan 20, 2026
Merged

Remove unwanted spaces in view tag templates (#556)#1508
jochenklar merged 2 commits into2.5.0/releasefrom
2.5.0/fix/view-tags

Conversation

@jochenklar
Copy link
Member

Resolves #556.

@jochenklar jochenklar requested a review from MyPyDavid January 8, 2026 10:53
@jochenklar jochenklar self-assigned this Jan 8, 2026
@jochenklar jochenklar added this to the RDMO 2.5.0 milestone Jan 8, 2026
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test needs to be fixed, because no more spaces?

db = None, client = <django.test.client.Client object at 0x7f05da1ce7d0>

    def test_project_answers_export_html(db, client):
        client.login(username='admin', ***'admin')
    
        url = reverse('project_answers_export', args=[1, 'html'])
        response = client.get(url)
    
        assert response.status_code == 200
    
        test_file = os.path.join(settings.BASE_DIR, 'export', 'project.html')
        for a, b in zip(response.content.decode().splitlines(), open(test_file).read().splitlines(), strict=True):
>           assert a == b
E           AssertionError: assert '            ...t amet</span>' == '<span>Lorem ...t amet</span>'
E             
E             - <span>Lorem ipsum dolor sit amet</span>
E             +                         <span>Lorem ipsum dolor sit amet</span>
E             ? ++++++++++++++++++++++++

rdmo/projects/tests/test_export.py:17: AssertionError
================================ tests coverage ================================

@jochenklar
Copy link
Member Author

I had it locally, not committed, but stashed ...

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jochenklar jochenklar merged commit 8926a05 into 2.5.0/release Jan 20, 2026
18 checks passed
@jochenklar jochenklar deleted the 2.5.0/fix/view-tags branch January 20, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants