Remove unwanted spaces in view tag templates (#556)#1508
Merged
jochenklar merged 2 commits into2.5.0/releasefrom Jan 20, 2026
Merged
Remove unwanted spaces in view tag templates (#556)#1508jochenklar merged 2 commits into2.5.0/releasefrom
jochenklar merged 2 commits into2.5.0/releasefrom
Conversation
MyPyDavid
requested changes
Jan 19, 2026
Member
MyPyDavid
left a comment
There was a problem hiding this comment.
a test needs to be fixed, because no more spaces?
db = None, client = <django.test.client.Client object at 0x7f05da1ce7d0>
def test_project_answers_export_html(db, client):
client.login(username='admin', ***'admin')
url = reverse('project_answers_export', args=[1, 'html'])
response = client.get(url)
assert response.status_code == 200
test_file = os.path.join(settings.BASE_DIR, 'export', 'project.html')
for a, b in zip(response.content.decode().splitlines(), open(test_file).read().splitlines(), strict=True):
> assert a == b
E AssertionError: assert ' ...t amet</span>' == '<span>Lorem ...t amet</span>'
E
E - <span>Lorem ipsum dolor sit amet</span>
E + <span>Lorem ipsum dolor sit amet</span>
E ? ++++++++++++++++++++++++
rdmo/projects/tests/test_export.py:17: AssertionError
================================ tests coverage ================================
Member
Author
|
I had it locally, not committed, but stashed ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #556.