Skip to content

Add version to static files in production #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jochenklar merged 2 commits into from
Feb 5, 2026
Merged

Add version to static files in production #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c12cd17
Overwrite static tag to include version
jochenklar Jan 16, 2026
906bbad
Use custom storage instead of static tag
jochenklar Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rdmo/core/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@
'compressor.finders.CompressorFinder',
)

STATICFILES_STORAGE = 'rdmo.core.storage.VersionedStaticFilesStorage'

DATABASES = {
'default': {
'ENGINE': 'django.db.backends.sqlite3',
Expand Down
18 changes: 18 additions & 0 deletions rdmo/core/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
from django.conf import settings
from django.contrib.staticfiles.storage import StaticFilesStorage

from rdmo import __version__


class VersionedStaticFilesStorage(StaticFilesStorage):

def url(self, name):
url = super().url(name)

if settings.DEBUG:
Copy link
Member

@MyPyDavid MyPyDavid Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have a if settings.DEBUG check anywhere in rdmo yet, should this not go in the rdmo-app?

Copy link
Member Author

@jochenklar jochenklar Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think its fine. settings.DEBUG is pretty low-level django. So far we did not need it.

return url
else:
if '?' in url:
return f'{url}&v={__version__}'
else:
return f'{url}?v={__version__}'
Loading