-
-
Notifications
You must be signed in to change notification settings - Fork 145
refactor: upgrade rc-trigger #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/react-component/cascader/6jzq7w14b |
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 100% 92.74% -7.26%
==========================================
Files 1 4 +3
Lines 1 262 +261
Branches 0 90 +90
==========================================
+ Hits 1 243 +242
- Misses 0 19 +19
Continue to review full report at Codecov.
|
|
@zombieJ 这个 now 需要权限么还是 |
|
This pull request introduces 1 alert and fixes 1 when merging 563f48f into ec54bfb - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 1 alert when merging 8c38a97 into ec54bfb - view on LGTM.com fixed alerts:
|
|
看起来是有问题 |
这个好奇怪,我之前用 windows 本地是正常的就没管他了,这个 Mac 就是有问题,看起来像是 rc-align 的问题,我本地的 rc-align 用回以前的版本就是正常的,我再看下 |
|
@zombieJ 这个 rc-align 改用 hook 后有问题,这个逻辑去哪了 |
|
https://github.com/react-component/align/blob/master/src/Align.tsx#L116 移到 resize monitor 里去了 |
恩,少了个 source 的 resize monitor |
|
This pull request fixes 1 alert when merging 7e6b7b7 into ec54bfb - view on LGTM.com fixed alerts:
|
|
now 是不是用了缓存,怎么 force 下 |
|
应该没有缓存,我 redeploy 了 |
|
恩,现在正常了 |
|
我感觉 OK 了,合了发版? |
|
恩,试试,这版没怎么改,后期还是要优化,这版主要是 ts 和 rc-trigger 升级 |
|
|

Ref: ant-design/ant-design#19169