Skip to content

Conversation

@shaodahong
Copy link
Member

@vercel
Copy link

vercel bot commented Nov 6, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/cascader/6jzq7w14b
🌍 Preview: https://cascader-git-upgrade-rc-trigger.react-component.now.sh

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #79 into master will decrease coverage by 7.25%.
The diff coverage is 89.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage     100%   92.74%   -7.26%     
==========================================
  Files           1        4       +3     
  Lines           1      262     +261     
  Branches        0       90      +90     
==========================================
+ Hits            1      243     +242     
- Misses          0       19      +19
Impacted Files Coverage Δ
src/placements.ts 100% <100%> (ø)
src/Cascader.tsx 94.18% <100%> (ø)
src/utils.ts 66.66% <66.66%> (ø)
src/Menus.tsx 93.5% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec54bfb...7e6b7b7. Read the comment docs.

@shaodahong shaodahong requested a review from zombieJ November 6, 2019 10:36
@shaodahong
Copy link
Member Author

@zombieJ 这个 now 需要权限么还是

@shaodahong shaodahong changed the title [WIP] refactor: upgrade rc-trigger refactor: upgrade rc-trigger Nov 6, 2019
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 6, 2019

This pull request introduces 1 alert and fixes 1 when merging 563f48f into ec54bfb - view on LGTM.com

new alerts:

  • 1 for Potentially inconsistent state update

fixed alerts:

  • 1 for Potentially inconsistent state update

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 6, 2019

This pull request fixes 1 alert when merging 8c38a97 into ec54bfb - view on LGTM.com

fixed alerts:

  • 1 for Potentially inconsistent state update

@shaodahong
Copy link
Member Author

@zombieJ
Copy link
Member

zombieJ commented Nov 8, 2019

看起来是有问题

@shaodahong
Copy link
Member Author

看起来是有问题

这个好奇怪,我之前用 windows 本地是正常的就没管他了,这个 Mac 就是有问题,看起来像是 rc-align 的问题,我本地的 rc-align 用回以前的版本就是正常的,我再看下

@shaodahong
Copy link
Member Author

@shaodahong
Copy link
Member Author

@zombieJ 这个 rc-align 改用 hook 后有问题,这个逻辑去哪了

https://github.com/react-component/align/blob/8418bba2ee01177cb8e3a4bccd02e3b7f4fe7388/src/Align.jsx#L83

@zombieJ
Copy link
Member

zombieJ commented Nov 11, 2019

@shaodahong
Copy link
Member Author

https://github.com/react-component/align/blob/master/src/Align.tsx#L116 移到 resize monitor 里去了

恩,少了个 source 的 resize monitor

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 12, 2019

This pull request fixes 1 alert when merging 7e6b7b7 into ec54bfb - view on LGTM.com

fixed alerts:

  • 1 for Potentially inconsistent state update

@shaodahong
Copy link
Member Author

now 是不是用了缓存,怎么 force 下

@zombieJ
Copy link
Member

zombieJ commented Nov 12, 2019

应该没有缓存,我 redeploy 了

@shaodahong
Copy link
Member Author

恩,现在正常了

@zombieJ
Copy link
Member

zombieJ commented Nov 12, 2019

我感觉 OK 了,合了发版?

@shaodahong
Copy link
Member Author

恩,试试,这版没怎么改,后期还是要优化,这版主要是 ts 和 rc-trigger 升级

@zombieJ zombieJ merged commit 24d1da5 into master Nov 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the upgrade-rc-trigger branch November 12, 2019 09:40
@zombieJ
Copy link
Member

zombieJ commented Nov 12, 2019

+ rc-cascader@1.0.0-alpha.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants