Skip to content

Pass title prop to input #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kilya11 wants to merge 4 commits into from
Closed

Pass title prop to input #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
664ff47
Type for the title prop
kilya11 Oct 23, 2019
b6e898d
Pass title prop
kilya11 Oct 23, 2019
dd4d633
Test title prop
kilya11 Oct 23, 2019
3994f65
Remove trailing spaces
kilya11 Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export interface Props {
name?: string,
id?: string,
type?: string,
title?: string,
defaultChecked?: number | boolean,
checked?: number | boolean,
disabled?: boolean,
Expand Down
5 changes: 4 additions & 1 deletion src/Checkbox.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ class Checkbox extends Component {
name: PropTypes.string,
id: PropTypes.string,
type: PropTypes.string,
title: PropTypes.string,
defaultChecked: PropTypes.oneOfType([PropTypes.number, PropTypes.bool]),
checked: PropTypes.oneOfType([PropTypes.number, PropTypes.bool]),
disabled: PropTypes.bool,
Expand Down Expand Up @@ -92,7 +93,7 @@ class Checkbox extends Component {

saveInput = (node) => {
this.input = node;
}
};

render() {
const {
Expand All @@ -102,6 +103,7 @@ class Checkbox extends Component {
name,
id,
type,
title,
disabled,
readOnly,
tabIndex,
Expand Down Expand Up @@ -132,6 +134,7 @@ class Checkbox extends Component {
name={name}
id={id}
type={type}
title={title}
readOnly={readOnly}
disabled={disabled}
tabIndex={tabIndex}
Expand Down
6 changes: 6 additions & 0 deletions tests/index.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ describe('rc-checkbox', () => {
expect(renderedInput.attributes.value.value).toEqual('6');
});

it('passes title prop to input', () => {
const wrapper = mount(<Checkbox title="my-custom-title" />);
const renderedInput = wrapper.find('input').instance();
expect(renderedInput.attributes.title.value).toEqual('my-custom-title');
});

it('focus()', () => {
const container = document.createElement('div');
document.body.appendChild(container);
Expand Down