-
-
Notifications
You must be signed in to change notification settings - Fork 116
feat: support custom cover placement #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
afc163
merged 1 commit into
react-component:master
from
kiner-tang:feat-support-actions-placement
Jul 17, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| title: coverPlacement | ||
| nav: | ||
| title: Demo | ||
| path: /demo | ||
| --- | ||
|
|
||
| <code src="../examples/coverPlacement.tsx"></code> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import type { CoverConfig } from '@rc-component/image'; | ||
| import Image from '@rc-component/image'; | ||
| import * as React from 'react'; | ||
| import '../../assets/index.less'; | ||
| import { defaultIcons } from './common'; | ||
|
|
||
| export default function Base() { | ||
| const [placement, setPlacement] = React.useState<CoverConfig["placement"]>('center'); | ||
| return ( | ||
| <div> | ||
| <div> | ||
| <label htmlFor="placement"> | ||
| <span>placement:</span> | ||
| </label> | ||
| <select id="placement" onChange={e => setPlacement(e.target.value as CoverConfig["placement"])} value={placement}> | ||
| <option value="top">top</option> | ||
| <option value="bottom">bottom</option> | ||
| <option value="center">center</option> | ||
| </select> | ||
| </div> | ||
| <br /> | ||
| <Image | ||
| src="https://zos.alipayobjects.com/rmsportal/jkjgkEfvpUPVyRjUImniVslZfWPnJuuZ.png" | ||
| width={200} | ||
| onClick={() => { | ||
| console.log('click'); | ||
| }} | ||
| preview={{ | ||
| icons: defaultIcons, | ||
| onOpenChange: open => { | ||
| console.log('open', open); | ||
| }, | ||
| zIndex: 9999, | ||
| cover: { | ||
| coverNode: 'Click to Preview', | ||
| placement, | ||
| }, | ||
| }} | ||
| /> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里有支持语义化结构,可以直接在 antd 里通过 classNames.cover 来扩展
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要在rc支持placement么
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要再 rc 组件支持 placement api 的话,我周末直接在 antd 上搞吧