fix: active wrong when submenus has key '' #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
reviewed
Jun 10, 2024
Comment on lines
75
to
87
| const isSubPathKey = useCallback( | ||
| (pathKeys: string[], eventKey: string) => | ||
| pathKeys.some(pathKey => { | ||
| (pathKeys: string[], eventKey: string) => { | ||
| if (pathKeys.every(key => key === undefined)) { | ||
| return false; | ||
| } | ||
| return pathKeys.some(pathKey => { | ||
| const pathKeyList = getKeyPath(pathKey, true); | ||
|
|
||
| return pathKeyList.includes(eventKey); | ||
| }), | ||
| }); | ||
| }, | ||
| [getKeyPath], | ||
| ); |
Member
There was a problem hiding this comment.
Suggested change
| const isSubPathKey = useCallback( | |
| (pathKeys: string[], eventKey: string) => | |
| pathKeys.some(pathKey => { | |
| (pathKeys: string[], eventKey: string) => { | |
| if (pathKeys.every(key => key === undefined)) { | |
| return false; | |
| } | |
| return pathKeys.some(pathKey => { | |
| const pathKeyList = getKeyPath(pathKey, true); | |
| return pathKeyList.includes(eventKey); | |
| }), | |
| }); | |
| }, | |
| [getKeyPath], | |
| ); | |
| const isSubPathKey = useCallback( | |
| (pathKeys: string[], eventKey: string) => | |
| pathKeys.filter(item => item !== undefined).some(pathKey => { | |
| const pathKeyList = getKeyPath(pathKey, true); | |
| return pathKeyList.includes(eventKey); | |
| }), | |
| [getKeyPath], | |
| ); |
Member
|
需要补充用例。 |
Contributor
Author
好，佬之前那个看一下react-component/upload#559 |
afc163
reviewed
Jun 10, 2024
afc163
reviewed
Jun 10, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
afc163
reviewed
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #719
close ant-design/ant-design#49106