Skip to content

fix: startTransition dead loop #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 1 commit into from
Feb 7, 2025
Merged

fix: startTransition dead loop #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/hooks/useNotification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,26 @@ export default function useNotification(
}
});

// https://github.com/ant-design/ant-design/issues/52590
// React `startTransition` will run once `useEffect` but many times `setState`,
// So `setTaskQueue` with filtered array will cause infinite loop.
// We cache the first match queue instead.
let oriTaskQueue: Task[];
let tgtTaskQueue: Task[];

// React 17 will mix order of effect & setState in async
// - open: setState[0]
// - effect[0]
// - open: setState[1]
// - effect setState([]) * here will clean up [0, 1] in React 17
setTaskQueue((oriQueue) => oriQueue.filter((task) => !taskQueue.includes(task)));
setTaskQueue((oriQueue) => {
if (oriTaskQueue !== oriQueue || !tgtTaskQueue) {
oriTaskQueue = oriQueue;
tgtTaskQueue = oriQueue.filter((task) => !taskQueue.includes(task));
}

return tgtTaskQueue;
});
}
}, [taskQueue]);

Expand Down