refactor: solve circule dependency #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kiner-tang
reviewed
Jun 12, 2023
| const RESPONSIVE = 'responsive' as const; | ||
| const INVALIDATE = 'invalidate' as const; | ||
|
|
||
| export type ComponentType = |
There was a problem hiding this comment.
这里删掉了导出，可能会导致有从这里引入的地方报错，需要将迁移 RawItem 中的相关代码在这边也导出一下，如：
export type { ComponentType } from './RawItem'
export { OverflowContext } from './RawItem'
kiner-tang
approved these changes
Jun 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 5 6 +1
Lines 211 211
Branches 71 72 +1
=======================================
Hits 207 207
Misses 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zombieJ
reviewed
Jun 14, 2023
src/RawItem.tsx
Outdated
| | React.FC<any> | ||
| | keyof React.ReactHTML; | ||
|
|
||
| export const OverflowContext = React.createContext<{ |
Member
There was a problem hiding this comment.
Context 放 RawItem 里太奇怪了，直接单独搞个 context.ts 文件吧
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate ant-design/ant-design#42750