Skip to content

Conversation

@cliffordfajardo
Copy link

@cliffordfajardo cliffordfajardo commented Jul 13, 2022

NOTE: this is a work was a work in progress code change.
❗ Please feel free to edit my pull request. I am not sure where to make all the necessary changes since there are many different variations of this component. I'm also 12 hours behind you so response time is slow (California time)

Summary

Allow name prop to be passed to <Select>

What is the bug?

CleanShot 2022-07-13 at 10 57 53@2x

Stackblitz example: https://stackblitz.com/edit/react-ts-zfrvws?file=App.tsx

Motivation for Change

  • maintain consistency with <Input>( https://github.com/react-component/input) which supports passing name prop, which allows follows standard HTML behavior/expectations
    ✅  <Input name="some_value" />.     // input from https://github.com/react-component/input
    ✅  <input name="some_value" />     // regular input
    ```
    
  • keep consistency with HTML standard, as <select> is allowed to have a name attribute (Specification docs)

Related

@vercel
Copy link

vercel bot commented Jul 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
select ✅ Ready (Inspect) Visit Preview Aug 6, 2022 at 0:29AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant