refactor!: split file handles into seperate function#117
Closed
jonkoops wants to merge 2 commits intoreact-dropzone:betafrom
Closed
refactor!: split file handles into seperate function#117jonkoops wants to merge 2 commits intoreact-dropzone:betafrom
jonkoops wants to merge 2 commits intoreact-dropzone:betafrom
Conversation
Collaborator
Author
|
This PR builds off the work from #114, so that should be merged first so this can be rebased on top. |
jonkoops
commented
Nov 22, 2024
| expect(files).toHaveLength(0); | ||
| }); | ||
|
|
||
| it("should return an empty array if drag event", async () => { |
Collaborator
Author
There was a problem hiding this comment.
I removed this test, as it was doing the exact same thing the test above is doing.
Pull Request Test Coverage Report for Build 12074930766Details
💛 - Coveralls |
jonkoops
force-pushed
the
split-file-handles
branch
from
50ec437 to
370ba45
Compare
Signed-off-by: Jon Koops <jonkoops@gmail.com>
Signed-off-by: Jon Koops <jonkoops@gmail.com> BREAKING CHANGE: Arrays of `FileSystemFileHandle` are now handled in a dedicated `fromFileHandles()` function.
jonkoops
force-pushed
the
split-file-handles
branch
from
370ba45 to
0e4a3ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Removes the handling of
FileSystemFileHandlearrays from thefromEvent()function, and moves it to a dedicatedfromFileHandles()function purposefully made for handling this data type. This reduces the need to handle polymorphic input and narrow down what the exact type should be infromEvent(). Additionally, this allows bundlers to more effectively tree-shake the module in case the other code is never used.Does this PR introduce a breaking change?
Yes, arrays of
FileSystemFileHandleare now handled in a dedicatedfromFileHandles()function. Users that were previously usingfromEvent()will now have to use this dedicated function instead.Other information
This also removes the notice that this feature is experimental, promoting
fromFileHandles()to a stable API in the next major.