Consider ctrl-click as non-left-click#498
Closed
assembled-michael wants to merge 1 commit intoreact-grid-layout:masterfrom
Closed
Consider ctrl-click as non-left-click#498assembled-michael wants to merge 1 commit intoreact-grid-layout:masterfrom
assembled-michael wants to merge 1 commit intoreact-grid-layout:masterfrom
Conversation
misumi-khoi-nguyen-01
approved these changes
Mar 29, 2023
|
Good |
Collaborator
|
Closing this PR as stale. This PR has been open since 2020 without being merged. If ctrl-click handling is still an issue, please open a fresh PR against the current codebase. Thank you for the contribution! |
Collaborator
|
Reopening - this is a correct fix for macOS ctrl+click behavior. |
STRML
added a commit
that referenced
this pull request
Dec 31, 2025
On macOS, ctrl+click opens the context menu (equivalent to right-click). This change prevents drag from starting when ctrl is held during click, matching the expected behavior. Closes #498
3 tasks
Collaborator
|
Closing in favor of #786 which implements this fix against the current codebase. Thank you for the contribution! |
STRML
added a commit
that referenced
this pull request
Dec 31, 2025
On macOS, ctrl+click opens the context menu (equivalent to right-click). This change prevents drag from starting when ctrl is held during click, matching the expected behavior. Closes #498
STRML
added a commit
that referenced
this pull request
Dec 31, 2025
On macOS, ctrl+click opens the context menu (equivalent to right-click). This change prevents drag from starting when ctrl is held during click, matching the expected behavior. Closes #498
STRML
added a commit
that referenced
this pull request
Dec 31, 2025
On macOS, ctrl+click opens the context menu (equivalent to right-click). This change prevents drag from starting when ctrl is held during click, matching the expected behavior. Closes #498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that the behavior on Draggable was different when right-clicking vs. ctrl-clicking, even though they should be treated the same. This modifies it so ctrl-clicks are not considered as left-clicks.