remove unnecessary global typescript namespace declaration#690
Closed
pgoldberg wants to merge 1 commit intoreact-grid-layout:masterfrom
Closed
remove unnecessary global typescript namespace declaration#690pgoldberg wants to merge 1 commit intoreact-grid-layout:masterfrom
pgoldberg wants to merge 1 commit intoreact-grid-layout:masterfrom
Conversation
Collaborator
|
Closing this PR as stale. This TypeScript namespace cleanup PR has been open since 2022 without being merged. If this typing issue persists, please open a fresh PR against the current codebase. Thank you for the contribution! |
Collaborator
|
Reopening - this fixes a legitimate TypeScript type pollution issue. |
|
Thanks @STRML! I believe we ended up working around this issue with a patch on our side, so the issue does still exist. A fix for this would still be valuable! |
STRML
added a commit
that referenced
this pull request
Dec 31, 2025
Removes the `declare module 'react-draggable'` wrapper from TypeScript definitions and uses direct exports instead. This fixes type pollution issues when multiple versions of react-draggable end up in a project's dependencies. The global module declaration is unnecessary as TypeScript will automatically associate the typings with the `react-draggable` module since they're declared in package.json. Closes #690
2 tasks
Collaborator
|
Closing in favor of #787 which implements this fix against the current codebase. Thank you for the contribution! |
STRML
added a commit
that referenced
this pull request
Dec 31, 2025
Removes the `declare module 'react-draggable'` wrapper from TypeScript definitions and uses direct exports instead. This fixes type pollution issues when multiple versions of react-draggable end up in a project's dependencies. The global module declaration is unnecessary as TypeScript will automatically associate the typings with the `react-draggable` module since they're declared in package.json. Closes #690
STRML
added a commit
that referenced
this pull request
Dec 31, 2025
Removes the `declare module 'react-draggable'` wrapper from TypeScript definitions and uses direct exports instead. This fixes type pollution issues when multiple versions of react-draggable end up in a project's dependencies. The global module declaration is unnecessary as TypeScript will automatically associate the typings with the `react-draggable` module since they're declared in package.json. Closes #690
STRML
added a commit
that referenced
this pull request
Dec 31, 2025
#787) Removes the `declare module 'react-draggable'` wrapper from TypeScript definitions and uses direct exports instead. This fixes type pollution issues when multiple versions of react-draggable end up in a project's dependencies. The global module declaration is unnecessary as TypeScript will automatically associate the typings with the `react-draggable` module since they're declared in package.json. Closes #690
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declaring a global module with
declare module 'react-draggable'is unnecessary, and can cause type pollution if multiple versions ofreact-draggableend up in a package.This is exemplified in this repro: https://github.com/pgoldberg/react-draggable-typings-bug
The global module declaration is not necessary. Typescript will appropriately associate the typings with the
react-draggablemodule, since the typings are declared in the package.json here:react-draggable/package.json
Line 24 in 44a8c6e