fix: support SSR environments where Element is not defined (#251) #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `draggableOpts.offsetParent` prop type used `PropTypes.instanceOf(Element)` which throws a ReferenceError in SSR/Node.js environments where the DOM global `Element` doesn't exist. This was introduced in a prior release that added the draggableOpts prop type definitions. The fix checks if Element is defined before using instanceOf.
|
No changes in the dependency files were detected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
Summary
The
draggableOpts.offsetParentprop type usedPropTypes.instanceOf(Element)which throws aReferenceError: Element is not definedin SSR/Node.js environments where the DOM globalElementdoesn't exist.This was likely introduced when the
draggableOptsprop type shape was expanded to includeoffsetParent. The fix checks ifElementis defined before usinginstanceOf, falling back toPropTypes.anyin SSR environments.Fix
Changed in
lib/propTypes.js:Test plan
@jest-environment node)