fix: skip call executeBuiltInValidation if no sub-fields left#12054
Merged
bluebill1049 merged 3 commits intoreact-hook-form:masterfrom Jul 5, 2024
Merged
Conversation
Member
|
thanks, could you plz add a test case for this as well? so it validates a correct ussecase. |
Contributor
Author
|
Sure! I'm a bit busy atm. Will try to add tests during the next week |
…Validation` called
Contributor
Author
|
@bluebill1049 done. Please, check. Kinda looks strange, but I was unable to directly mock |
bluebill1049
approved these changes
Jul 5, 2024
bluebill1049
changed the title
executeBuiltInValidation if no sub-fields leftexecuteBuiltInValidation if no sub-fields left
Member
|
thanks for the improvement. |
This was referenced Sep 15, 2024
oskarski
pushed a commit
to oskarski/react-hook-form
that referenced
this pull request
Oct 1, 2024
…act-hook-form#12054) * fix: don't call `executeBuiltInValidation` if no sub-fields left * refactor: use `isEmptyObject` * chore: add tests to check the correct number of times `executeBuiltInValidation` called
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had a performance issue with
useFieldArrayand too many rows with validated fields. I've noticed that with function do some extra recursion with empty anfieldValuewhich mostly the reason of our issues