doctor: Add check for `adb devices`

[arushikesarwani94]

Describe the Feature

I'd like to propose a feature for doctor that will verify if the android device is attached correctly by listing the available devices. This could be a non-required check/ Warning ● in Common category to notify users of whether there is an attached device or not. This will allow users to differentiate device connection issues like : USB debugging enabled, developer options enabled etc. from others.

At times, restarting the adb server through adb kill-server; adb start-server might be helpful seeing this check failure rather than struggling to understand why the app launch is failing.

Possible Implementations

Fetch available devices (adb device) and emulators (emulator -list-avds)

Test Plan

1. Build cli codebase using : node ./scripts/build.js && yarn build:debugger
2. Link the cli-doctor using : yarn link
3. In the example React Native app(Awesome Project), run yarn link "@react-native-community/cli-doctor"
4. Run the CLI Doctor using : npx @react-native-community/cli doctor

Related Issues

#1765(Android)
#1676(iOS)

[cortinico]

That's really cool + I think doctor should also call adb reverse --list and verify if the reverse proxy for the physical device has been set. If not, the autofix woudl be to call adb reverse tcp:8081 tcp:8081

[adamTrz]

Nice feature @arushikesarwani94 would you like to go on and implement it? 🙂
There's a util function listAndroidDevices that already lists all available devices/emulators so we can start from there :)

[arushikesarwani94]

@adamTrz ATM we are not prioritising implementing these enhancements to cli-doctor ourselves but would encourage community contributions on these pieces so that folks are more aware of using cli-doctor as part of their set-up. WDYT ?

[adamTrz]

Very nice idea :) Let's see how it goes then 🙂

[ShaswatPrabhat]

I can give this a shot @adamTrz if seeking contributions.

[arushikesarwani94]

I can give this a shot @adamTrz if seeking contributions.

Did a basic implementation of adb devices and reverse proxy in #1880

Feel free to build on top of it. Things TODO :

• Fetch emulator along with adb devices
• Try Run Adb Reverse as part of the fix
• Refactor listAndroidDevices() to separate out getting allDevices and then use that in both places.
• Adding test for adb check

Maybe we could also utilise directly :
https://github.com/react-native-community/cli/blob/main/packages/cli-platform-android/src/commands/runAndroid/index.ts#L274

[adamTrz]

Fixed with #1885